Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: default preflights to preflights layer #1190

Merged
merged 2 commits into from Jun 30, 2022
Merged

Conversation

CanRau
Copy link
Contributor

@CanRau CanRau commented Jun 29, 2022

Trying to address #1186 though I'm not exactly sure I understand the code enough, so I don't know if those two places are sufficient or if I missed something.

Please let me know if there's more to it.

Quoting myself from #1186 for a little more inline-context

I think this is really confusing as I'm specifically defining a preflight here, so I'd expect it to be in preflight and therefore ordered before other styles instead of needing to manually "duplicate" my intend.

Closes #1186

@CanRau CanRau requested a review from antfu as a code owner June 29, 2022 21:20
@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 23c4758
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62bd0d4aac2215000821b858
😎 Deploy Preview https://deploy-preview-1190--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@CanRau CanRau changed the title Default preflights layers to preflights Default preflights to preflights layer Jun 29, 2022
@antfu antfu changed the title Default preflights to preflights layer feat(core)!: default preflights to preflights layer Jun 30, 2022
@antfu antfu merged commit 103a6de into unocss:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preflights styles should default to preflights layer instead of default
2 participants