fix(variant-group)!: remove quotes matching, add option to config seperator #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss canceled.
|
antfu
reviewed
Jul 8, 2022
| const file = await readFile('./test/assets/variant-group.vue', 'utf-8') | ||
| const result = await transform(file) | ||
| expect(result).toMatchInlineSnapshot(` | ||
| "<script setup lang=\\"ts\\"> | ||
| const a = 1 | ||
| const b = 2 | ||
| // eslint-disable-next-line @typescript-eslint/space-infix-ops | ||
| const c = a-(b -a -b) |
There was a problem hiding this comment.
But this one is a JS that should not be transformed.
There was a problem hiding this comment.
Yes, but there is no good way to solve this problem.
I think this is a very rare case where no one would write arithmetic this way, and we can either wait for this problem to appear and then solve it, or provide an option to disable the -transform.
|
I do like the improvement of magic string tho |
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1215
revert #831 (Matching the content of quotes can get very complicated)
And Fix the problem that repeated use of MagicString.replace does not work. refer Rich-Harris/magic-string#208