Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): add html to the default includes #1265

Merged
merged 1 commit into from Jul 14, 2022
Merged

fix(vscode): add html to the default includes #1265

merged 1 commit into from Jul 14, 2022

Conversation

adamburgess
Copy link
Contributor

As mentioned in the readme:

By default UnoCSS will scan for components files like: .jsx, .tsx, .vue, .md, .html, .svelte, .astro.

But it wasn't in the array. Feel free to close if this isn't necessary.

It was a bit confusing to me how index.html was included when I was using the vite plugin, but when I was using the vscode extension, it wasn't included.

@adamburgess adamburgess requested a review from antfu as a code owner July 14, 2022 19:48
@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fe24b60
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62d0730efea32200093bcc8c
😎 Deploy Preview https://deploy-preview-1265--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu
Copy link
Member

antfu commented Jul 14, 2022

Vite handles HTML in a different pipeline. And yeah that make sense for the extension since the list is reused.

@antfu antfu changed the title fix: add html to the default includes fix(vscode): add html to the default includes Jul 14, 2022
@antfu antfu merged commit b190e37 into unocss:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants