Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): use defineNuxtPlugin #1269

Merged
merged 1 commit into from Jul 16, 2022

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Jul 15, 2022

Linked issues

Fixes #1264

Description

Starting from nuxt@3.0.0-rc.5, Nuxt plugins not using defineNuxtPlugin are considered as invalid and will throw a warning (nuxt/framework#5857).

This PR makes @unocss/nuxt inner Nuxt plugin valid by simply using defineNuxtPlugin.

@kevinmarrec kevinmarrec requested a review from antfu as a code owner July 15, 2022 10:01
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 56f78eb
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/62d13b043b875b000863176d
😎 Deploy Preview https://deploy-preview-1269--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit 1081ca5 into unocss:main Jul 16, 2022
@kevinmarrec kevinmarrec deleted the fix-nuxt-plugin-warning branch July 16, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants