Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): editor highlight for variant groups #1468

Merged
merged 4 commits into from Aug 26, 2022
Merged

feat(editor): editor highlight for variant groups #1468

merged 4 commits into from Aug 26, 2022

Conversation

itpropro
Copy link
Contributor

  • Updated extractor regex
  • Updated getMatchedPositions
  • Added and updated tests

Currently, only the classes inside of the variant group are highlighted, not the variant itself (e.g. with hover:(bg-red-400 h-4), hover: will still not be highlighted).

@itpropro itpropro requested a review from antfu as a code owner August 26, 2022 00:07
@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 1bdbfee
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63086e79bda33d000909eed4
😎 Deploy Preview https://deploy-preview-1468--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu changed the title feat: Updated regex for variant groups feat(editor): editor highlight for variant groups Aug 26, 2022
@antfu antfu enabled auto-merge (squash) August 26, 2022 06:57
@antfu antfu merged commit 15c4f56 into unocss:main Aug 26, 2022
@itpropro
Copy link
Contributor Author

Thanks for improving @antfu, I'm just getting started with the codebase 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants