perf(core): filter rulesDynamic in resolveConfig
#1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for unocss failed.
|
zyyv
reviewed
Sep 4, 2022
| @@ -1,12 +1,12 @@ | |||
| import type { Extractor } from '../types' | |||
| import { isValidSelector } from '../utils' | |||
|
|
|||
| export const splitCode = (code: string) => code.split(/\\?[\s'"`;={}]+/g).filter(isValidSelector) | |||
| export const splitCode = (code: string) => [...new Set(code.split(/\\?[\s'"`;={}]+/g))].filter(isValidSelector) | |||
There was a problem hiding this comment.
I think it does the same job as his name, just to simply split the code. Deduplication should be handed over to the next step. (Just my opinion 😄)
|
Nice catch! Thanks |
antfu
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
@unocss/corerulesDynamicis being filtered and reversed inresolveConfig, this yields a ~10ms improvement on the new benchmark.extractorSplitnow first de-dupe via set then test the string. The impact is minimal, but faster on dedicated benchmark.forEach. The impact is again minimal, but it's nice to have.Changes to the benchmark
buildStarttocloseBundle, instead ofbuildEnd.The old benchmark is... flawed at best.
Since both TailwindCSS and WindiCSS generate their CSS before
buildEnd, and UnoCSS generates it's CSS ingenerateBundlewhich is afterbuildEnd. The benchmark doesn't actually measure the full build time for UnoCSS, but only part of the extraction time.To make the benchmark result more realistic, and better for future comparisons, the new one measures the full build time, which now includes CSS generation time.