feat(vite)!: svelte-scoped automatic compilation #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…velte-scoped mode
…Code extension as well
…into scoped-compilation
…hen coming at the beginning of a shortcut name
|
@antfu Can you please take another look at this to see if it's good to merge or give advice on what to change? I'd love to help with some of the other SvelteKit related issues like #1774 as well as dig into further explorations of how to smoothly integrate the Inspector and typography plugin in a context where a global stylesheet is not the default place to put all styles. But I think this PR is already big enough. |
jacob-8
commented
Oct 25, 2022
Comment on lines
+31
to
+34
| return prettier(transformed, { | ||
| parser: 'svelte', | ||
| plugins: [prettierSvelte], | ||
| }) |
There was a problem hiding this comment.
@antfu, wow, thank you for this! So much easier to read the test results. Initially I tried prettierCSS as seen elsewhere but obviously that didn't work since there's more than CSS in the test results.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1676
I've written test cases for every situation described in #1676 and a few less common ones as well. As can be seen by running the tests and the updated
svelte-scopedexample project, theSvelteScopedPluginis now fully ready for use in exactly the same manner as is available using global styles, except that each component carries the weight of its own CSS.Merging this will prepare the way for #1718.