Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): load config twice #1714

Merged
merged 4 commits into from Oct 9, 2022
Merged

fix(cli): load config twice #1714

merged 4 commits into from Oct 9, 2022

Conversation

avxit
Copy link
Contributor

@avxit avxit commented Oct 9, 2022

This should fix #1689 .

@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 365d5df
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6342c91d4083cf0009165e8d
😎 Deploy Preview https://deploy-preview-1714--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sudongyuer
Copy link
Member

test failed

@zyyv zyyv marked this pull request as draft October 9, 2022 10:39
@avxit
Copy link
Contributor Author

avxit commented Oct 9, 2022 •
edited

test failed

Yeah..., wrong cwd and the test failed. I don't know whether should I modified createContext to accept cwd or not?

image

image

@zyyv
Copy link
Member

zyyv commented Oct 9, 2022

Yes, i agree with you. But it looks a bit ...

@avxit
Copy link
Contributor Author

avxit commented Oct 9, 2022

Yes, i agree with you. But it looks a bit ...

I've updated the PR with ctx.updateRoot to update correct cwd.

@avxit avxit marked this pull request as ready for review October 9, 2022 12:03
@antfu antfu merged commit 1a11f48 into unocss:main Oct 9, 2022
@avxit avxit deleted the fix-load-config-twice branch October 11, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@zyyv zyyv zyyv approved these changes

@johannschopplich johannschopplich Awaiting requested review from johannschopplich johannschopplich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@unocss/cli warn about duplication of preset
4 participants
@avxit @sudongyuer @zyyv @antfu