fix(vscode): attributify value starts with number #1811
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/shared-common/src/index.ts
Outdated
| @@ -78,7 +78,7 @@ export function getMatchedPositions(code: string, matched: string[], hasVariantG | |||
|
|
|||
| // attributify values | |||
| attributify.forEach(([, name, value]) => { | |||
| const regex = new RegExp(`(${e(name)}=)(['"])[^\\2]*?${e(value)}[^\\2]*?\\2`, 'g') | |||
| const regex = new RegExp(`(${name}=)(['"])[^\\2]*?${value}[^\\2]*?\\2`, 'g') | |||
There was a problem hiding this comment.
Shouldn't e at least be replaced with escapeRegEx?
There was a problem hiding this comment.
I looked at this function, but I'm sorry, I didn't figure out what it means. Can you explain it in detail?
There was a problem hiding this comment.
I looked at this function, but I'm sorry, I didn't figure out what it means. Can you explain it in detail?
There was a problem hiding this comment.
I'm sorry the function name was escapeRegExp. (see search)
This is usually done if you are using string from variable while constructing regex, similar to escaping string variable with e() or the like before using it in html.
There was a problem hiding this comment.
@chu121su12 Thanks, you are right, I have replaced e() with escapeRegExp() and added tests.
zhmushan
force-pushed
the
vscode_attr_starts_with_number
branch
from
e6359fa
to
5188421
Compare
zhmushan
requested review from
chu121su12 and
sudongyuer
and removed request for
antfu and
chu121su12
The string to be tested here is the source code and does not need to be "escaped".