Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vscode): selection style #1840

Merged
merged 7 commits into from Nov 9, 2022
Merged

feat(vscode): selection style #1840

merged 7 commits into from Nov 9, 2022

Conversation

lishaobos
Copy link
Contributor

@lishaobos lishaobos commented Nov 3, 2022 •
edited

feat(vscode): Selection style

#1834

@lishaobos lishaobos requested a review from antfu as a code owner November 3, 2022 09:09
@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited

✅ Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 5b61afd
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/636a5e313800ca000acfe15a
😎 Deploy Preview https://deploy-preview-1840--unocss.netlify.app/play
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lishaobos
Copy link
Contributor Author

lishaobos commented Nov 3, 2022 •
edited

sorry, i forgot the test, may i exec : pnpm run test:ci, thanks.

@antfu

@sudongyuer
Copy link
Member

sorry, i forgot the test, may i exec : pnpm run test:ci, thanks.

@antfu

Hi，you can chekout this contribute guide of antfu‘s https://github.com/antfu/contribute

@yuanquan8
Copy link

Looking forward to it

@lishaobos lishaobos changed the title Selection style feat(vscode): Selection style Nov 4, 2022
@lishaobos
Copy link
Contributor Author

i fixed the type check.

@lishaobos
Copy link
Contributor Author

sorry, i forgot the test, may i exec : pnpm run test:ci, thanks.
@antfu

Hi，you can chekout this contribute guide of antfu‘s https://github.com/antfu/contribute

thank you

@antfu antfu changed the title feat(vscode): Selection style feat(vscode): selection style Nov 9, 2022
@antfu antfu enabled auto-merge (squash) November 9, 2022 02:52
@antfu antfu merged commit 32daed0 into unocss:main Nov 9, 2022
@lishaobos
Copy link
Contributor Author

@antfu

hi，i found some bugs with media:

expacted:

image

actually:

image

@lishaobos
Copy link
Contributor Author

i am pushing...

This was referenced Nov 9, 2022
Closed
Merged
praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
@lishaobos @cuiluc
@antfu @praburangki
feat(vscode): selection style (unocss#1840)
25e3970 
Co-authored-by: cuiluc <cuilulu4043@126.com>
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lishaobos @sudongyuer @yuanquan8 @antfu @cuiluc