Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): selection style with media #1863

Merged
merged 5 commits into from Nov 9, 2022
Merged

fix(vscode): selection style with media #1863

merged 5 commits into from Nov 9, 2022

Conversation

lishaobos
Copy link
Contributor

fix: #1840

expacted:

image

actually:

image

@lishaobos lishaobos requested a review from antfu as a code owner November 9, 2022 07:32
@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit c449060
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/636b5ae271f17200097ac3c2
😎 Deploy Preview https://deploy-preview-1863--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lishaobos lishaobos changed the title fix: selection style fix: selection style with media Nov 9, 2022
@antfu antfu changed the title fix: selection style with media fix(vscode): selection style with media Nov 9, 2022
@antfu antfu merged commit dbee1fd into unocss:main Nov 9, 2022
@lishaobos
Copy link
Contributor Author

lishaobos commented Nov 9, 2022

@antfu

sorry, man, i still found some bug or optimize in your commit

😂😂😂

  1. when i select this area, can not show anything(i think user just use it, do not need think about touch or select).

image


image
image

  1. style should be merge

image

for my commit,this will make it clearer

image

@lishaobos
Copy link
Contributor Author

i am so so so sorry 😂😂😂

praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
Co-authored-by: cuiluc <cuilulu4043@126.com>
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants