Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode selection style(bug or optimize) #1864

Closed
lishaobos opened this issue Nov 9, 2022 · 4 comments
Closed

vscode selection style(bug or optimize) #1864

lishaobos opened this issue Nov 9, 2022 · 4 comments

Comments

@lishaobos
Copy link
Contributor

lishaobos commented Nov 9, 2022

@antfu

history: #1863

sorry, man, i still found some bug or optimize in your commit

😂😂😂

  1. when i select this area, can not show anything(i think user just use it, do not need think about touch or select).

image


image
image

  1. style should be merge

image

for my commit,this will make it clearer

image

Originally posted by @lishaobos in #1863 (comment)

@antfu
Copy link
Member

antfu commented Nov 10, 2022

The first one is intentional. The second one is open for PR.

@lishaobos
Copy link
Contributor Author

The first one is intentional. The second one is open for PR.

hi,for the seconed one,you have changed my pr c449060, should i repeat commit ?

@antfu
Copy link
Member

antfu commented Nov 11, 2022

Let me think a bit, I will fix it. I was doing the refractor to reduce the code complexity.

@lishaobos
Copy link
Contributor Author

Let me think a bit, I will fix it. I was doing the refractor to reduce the code complexity.

ok, thanks for your work!!!

@antfu antfu closed this as completed in b0ddc84 Nov 13, 2022
praburangki pushed a commit to praburangki/unocss that referenced this issue Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants