Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): introduce the injectExtra option #1878

Merged
merged 3 commits into from Nov 18, 2022
Merged

feat(astro): introduce the injectExtra option #1878

merged 3 commits into from Nov 18, 2022

Conversation

equt
Copy link
Contributor

@equt equt commented Nov 15, 2022

This commit also marks the existing injectReset & injectEntry as deprecated. Users with those options set should have no breaking changes on their existing code, but only receive a warning via the linting tool.

close #1877

@equt equt requested a review from antfu as a code owner November 15, 2022 01:57
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e59b61
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6376d664a9bad30008205088
😎 Deploy Preview https://deploy-preview-1878--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu
Copy link
Member

antfu commented Nov 17, 2022

I don't think we should depreciate the existing ones. But maybe name it injectExtra: [] or so.

@equt
Copy link
Contributor Author

equt commented Nov 18, 2022

I don't think we should depreciate the existing ones. But maybe name it injectExtra: [] or so.

make sense

This commit also marks the existing `injectReset` & `injectEntry` as
deprecated. Users with those options set should have no breaking changes
on their existing code, but only receive a warning via the linting tool.

close #1877
@equt equt changed the title feat(astro): introduce injects option feat(astro): introduce the injectExtra option Nov 18, 2022
@antfu antfu merged commit f2fda68 into unocss:main Nov 18, 2022
@equt equt deleted the fix/astro-reset-injection branch December 20, 2022 01:33
praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom injections in @unocss/astro
2 participants