Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preset-mini): support arbitrary properties with quotes #1904

Merged
merged 6 commits into from Nov 24, 2022
Merged

feat(preset-mini): support arbitrary properties with quotes #1904

merged 6 commits into from Nov 24, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Nov 22, 2022 •
edited

@sibbng sibbng requested a review from antfu as a code owner November 22, 2022 21:35
@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited

✅ Deploy Preview for unocss canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0288d5a
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/637e677633f3fc0009cc6684

antfu
antfu approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you have any numbers on the perf cost?

@sibbng
Copy link
Member Author

sibbng commented Nov 23, 2022

cli build: main branch vs this pr with 200+ html files (Benchmark 2 is main branch):

image

Also ran pnpm run bench on each branch, numbers are the same.

@antfu antfu merged commit 22c4e70 into unocss:main Nov 24, 2022
@sibbng sibbng deleted the feat/support-arbitrary-properties branch November 24, 2022 18:23
praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
@sibbng @praburangki
feat(preset-mini): support arbitrary properties with quotes (unocss#1904
d23ee37 
)
@renovate renovate bot mentioned this pull request Jan 29, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sibbng @antfu