fix(transformer-directives,nuxt): revert enforce: 'pre', disable mergeRules
#1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Dec 18, 2022
praburangki
pushed a commit
to praburangki/unocss
that referenced
this pull request
Jan 12, 2023
…ergeRules` (unocss#1930) * fix(transformer-directives,nuxt): revert `enforce: 'pre'`, disable `mergeRules` * fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1923
Fixes #1929
Fixes #1849 by disabling cssnano's mergeRules optimization if transformer-directive is detected in nuxt module. esbuild already merges the rules
Also fixes an issue where getConfig always returns an empty object. I discovered it while debugging the issue.
unocss/packages/shared-integration/src/context.ts
Lines 92 to 95 in 9c89d93