Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't patch cssnano config for nuxt2 #2010

Merged
merged 1 commit into from Dec 18, 2022
Merged

fix(nuxt): don't patch cssnano config for nuxt2 #2010

merged 1 commit into from Dec 18, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Dec 18, 2022

Fixes #2009

I was about to implement #1930 patch for Nuxt 2, but it seems transformer-directives don't work at all in Nuxt 2. So, this PR fixes #2009 by limiting it to Nuxt 3.

@sibbng sibbng requested a review from antfu as a code owner December 18, 2022 22:06
@netlify
Copy link

netlify bot commented Dec 18, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 1371585
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/639f8eef3c22160008bca94d
😎 Deploy Preview https://deploy-preview-2010--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@antfu antfu merged commit 996b915 into main Dec 18, 2022
@antfu antfu deleted the fix/nuxt2 branch December 18, 2022 22:44
praburangki pushed a commit to praburangki/unocss that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'plugins')
2 participants