feat(vite): introduce hmrTopLevelAwait option
#2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Similar to #1981 |
|
I think we should better make an option, so ppl can opt-out if needed, while the majority could still benefit from it. |
I added a switch to the top-level await feature in the configuration. I'm not familiar with the unocss code yet, so feel free to point out if there is something wrong with the changes |
zyyv
reviewed
Jan 12, 2023
playground/vite.config.ts
Outdated
| @@ -13,7 +13,9 @@ export default defineConfig({ | |||
| }, | |||
| plugins: [ | |||
| Vue(), | |||
| Unocss(), | |||
| UnoCSS({ | |||
| topLevelAwait: false, | |||
antfu
reviewed
Jan 12, 2023
zyyv
reviewed
Jan 12, 2023
playground/vite.config.ts
Outdated
| @@ -13,7 +13,9 @@ export default defineConfig({ | |||
| }, | |||
| plugins: [ | |||
| Vue(), | |||
| Unocss(), | |||
| UnoCSS({ | |||
| hmrTopLevelAwait: false, | |||
There was a problem hiding this comment.
Please allow me add this option to test uno's vite plugin, it doesn't affect anything. @antfu
|
Thank you very much for helping me to improve the code |
antfu
changed the title
hmrTopLevelAwait option
Closed
4 tasks
This was referenced Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes I need to develop in restricted environments to debug the compatibility of certain code on a particular platform, but recently unocss has been using top-level await's in development mode, causing my code to not work properly in these restricted environments, which makes it very inconvenient to have to build and release the project for testing.
fix #2031, fix #2025, close #1981