fix(core): replace scope placeholder globally #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM, but I didn't get what is breaking. |
antfu
reviewed
Jan 22, 2023
packages/core/src/generator/index.ts
Outdated
Comment on lines
640
to
643
| const regexScopeCheck = / \$\$ / | ||
| export const regexScopePlaceholder = / +\$\$ +/g | ||
| function applyScope(css: string, scope?: string) { | ||
| if (hasScopePlaceholder(css)) | ||
| if (css.match(regexScopeCheck)) |
There was a problem hiding this comment.
export const regexScopePlaceholder = /\s\$\$\s+/g
export const hasScopePlaceholder = (css: string) => css.match(/\s\$\$\s/)
function applyScope(css: string, scope?: string) {
if (hasScopePlaceholder(css))Can't we do this?
antfu
changed the title
antfu
approved these changes
Jan 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2068
I'd tag this as breaking since the replacement is now global while exported and being used in 2 other places:
unocss/packages/vscode/src/selectionStyle.ts
Line 54 in badcf86
unocss/packages/transformer-directives/src/apply.ts
Line 66 in badcf86