Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini)!: allow empty string for variablePrefix #2093

Merged
merged 1 commit into from Jan 25, 2023

Conversation

chu121su12
Copy link
Collaborator

Close #2085

Tagged as breaking since previously empty string will become the default --un instead.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 91ea6a7
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63c7def98bc1aa00096976c1
😎 Deploy Preview https://deploy-preview-2093--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chu121su12 chu121su12 marked this pull request as ready for review January 18, 2023 12:05
@zyyv
Copy link
Member

zyyv commented Jan 19, 2023

How about set the type of variablePrefix to boolean | string?

  • If variablePrefix's value is false, it means to disable variablePrefix default string(use empty string).
  • If variablePrefix's value is true, it means use un-.
  • If it's a string, it means user custom variablePrefix.

@antfu antfu merged commit fcab142 into unocss:main Jan 25, 2023
@chu121su12 chu121su12 deleted the feat/empty-prefix branch February 23, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow variablePrefix to be disabled
3 participants