Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reset): add tailwind-compat.css #2128

Merged
merged 8 commits into from Feb 24, 2023
Merged

feat(reset): add tailwind-compat.css #2128

merged 8 commits into from Feb 24, 2023

Conversation

kirklin
Copy link
Contributor

@kirklin kirklin commented Jan 29, 2023

fix background color of some button styles in component libraries are lost when referencing the tailwind.css file.
Link: #2127

@kirklin kirklin requested a review from antfu as a code owner January 29, 2023 09:09
@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for unocss canceled.

Name Link
🔨 Latest commit e6632b7
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/63f89f294639340008cd520e

@antfu
Copy link
Member

antfu commented Jan 29, 2023

That's something I have wanted for a while! Here are a few questions about it that we better address before having it:

  • We should give a clear definition of how it works. Like "Based on Tailwind's preflight but without background color", or a list of the changes in the README. This will help users understand it, and also for future maintenance to know how to update (or keep sync with Tailwind).
  • Maybe @unocss/reset/minimal.css? Since both uno- and reset are already present and does not provide more information.

@kirklin
Copy link
Contributor Author

kirklin commented Feb 9, 2023

Do I need to rename uno-reset.css to minimal.css ?

@antfu antfu changed the title feat(reset): add uno-reset.css feat(reset): add tailwind-compat.css Feb 24, 2023
@antfu antfu merged commit 601a61c into unocss:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants