fix(vscode): fix the regressions caused by #2256 #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sibbng
force-pushed
the
fix/vscode-highlighting
branch
from
8942a52
to
4f284cc
Compare
antfu
reviewed
Feb 27, 2023
| }, | ||
| }) | ||
|
|
||
| expect(await match(uno, '<div border></div><div <custom-shortcut></div>')) |
There was a problem hiding this comment.
This is so weird, is it even a valid char in attribute?
There was a problem hiding this comment.
I don't know the specification part. The only thing I can say is Nu Html Checker didn't like it https://validator.w3.org/nu/#cl1c5 But on the browser's side, it's just working. So, if the browser parser is fault-tolerant enough to support it, so should we. You can think of it as a stability test. It's not there because we endorse it, it's there because we're capable of it. Benefitting from it is up to end users.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some regressions caused by #2256 and adds proper support for variant groups