feat(transformer-attributify-jsx-babel): new transformer #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Apr 7, 2023
Comment on lines
48
to
50
| "@babel/core": "^7.21.0", | ||
| "@babel/plugin-syntax-jsx": "^7.18.6", | ||
| "@babel/preset-typescript": "^7.21.0", |
There was a problem hiding this comment.
Maybe we should not bundle them?
And I just checked, and it seems that @unocss/transformer-attributify-jsx is included in unocss, which I don't really willing as deps on babel. If you think it's worth to have the babel transformations I guess maybe we should stop including them by default, or make another babel specific preset.
There was a problem hiding this comment.
I moved babel transformer to a new package and not included it on unocss. I updated readmes and configurations as well. It should be ready to release if I didn't miss anything.
antfu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds experimental babel transformer strategy to
transformer-attributify-jsx.Usage: