Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro)!: disable injected reset styles by default #2377

Merged
merged 4 commits into from
Apr 9, 2023

Conversation

Hongbusi
Copy link
Contributor

When using unocss in Astro without installing @unocss/reset, an error will occur.

Therefore , the default value of injectReset was changed to false because I believe this choice should be left to the user.

@Hongbusi Hongbusi requested a review from antfu as a code owner March 21, 2023 02:46
@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit fafb318
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/643277cb46d6b10008c15ee5
😎 Deploy Preview https://deploy-preview-2377--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zyyv
Copy link
Member

zyyv commented Mar 22, 2023

@unocss/reset in dependencies, it should be installed in node_modules

"dependencies": {
"@unocss/core": "workspace:*",
"@unocss/reset": "workspace:*",
"@unocss/vite": "workspace:*"
},

When using unocss in Astro without installing @unocss/reset, an error will occur.
I don't find any error in example/astro

@Hongbusi
Copy link
Contributor Author

Should be set shamefully-hoist=true to be installed in node_modules.

Because unocss is a monorepo repository, @unocss/reset is introduced in the top-level package.json, so you don't report an error in example/astro.

@antfu antfu changed the title fix(astro): remove default injected reset styles fix(astro)!: disable injected reset styles by default Apr 9, 2023
@antfu antfu merged commit 11864ad into unocss:main Apr 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants