Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-wind): align with line-clamp #2437

Merged
merged 4 commits into from
Apr 4, 2023
Merged

fix(preset-wind): align with line-clamp #2437

merged 4 commits into from
Apr 4, 2023

Conversation

zyyv
Copy link
Member

@zyyv zyyv commented Apr 4, 2023

@zyyv zyyv requested a review from antfu as a code owner April 4, 2023 09:00
@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 25407ec
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/642c554db276900009e33e22
😎 Deploy Preview https://deploy-preview-2437--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zyyv zyyv changed the title fix(preset-mini): align with line-clamp fix(preset-wind): align with line-clamp Apr 4, 2023
@zyyv zyyv changed the title fix(preset-wind): align with line-clamp fix(preset-wind): align with line-clamp Apr 4, 2023
'-webkit-line-clamp': keyword,
'line-clamp': keyword,
Copy link
Member

@antfu antfu Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove this, for future usage and make it no webkit-only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's ok to align with TW, but I think it's better to keep the non-prefixed one

@zyyv zyyv closed this Apr 4, 2023
@zyyv zyyv deleted the mini/line-clamp branch April 4, 2023 13:11
@zyyv zyyv restored the mini/line-clamp branch April 4, 2023 16:46
@zyyv zyyv reopened this Apr 4, 2023
@antfu antfu merged commit 178819d into unocss:main Apr 4, 2023
9 checks passed
@zyyv zyyv deleted the mini/line-clamp branch April 10, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants