Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-web-fonts): custom provider support #2535

Closed
wants to merge 2 commits into from
Closed

feat(preset-web-fonts): custom provider support #2535

wants to merge 2 commits into from

Conversation

maxswjeon
Copy link

This PR enables custom provider for @unocss/preset-web-fonts.

Custom fonts are provided by url, but not on google fonts.

May close #2237

@maxswjeon maxswjeon requested a review from antfu as a code owner April 23, 2023 07:08
@netlify
Copy link

netlify bot commented Apr 23, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e8d04a
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6444dabe4a693c00097b70e2
😎 Deploy Preview https://deploy-preview-2535--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maxswjeon maxswjeon changed the title feat: custom provider support feat(preset-web-fonts): custom provider support Apr 23, 2023
@antfu antfu closed this in ca4f668 Apr 23, 2023
@maxswjeon
Copy link
Author

Umm... Can I get a reason why this was closed without any comments?

@antfu
Copy link
Member

antfu commented Apr 23, 2023

Please check the linked commit, it's implemented in another way.

@antfu
Copy link
Member

antfu commented Apr 23, 2023

#2237 (comment)

@maxswjeon
Copy link
Author

Aha. I missed the original issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: enable providers to resolve to custom urls
2 participants