New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformer-compile-class): support for custom class names #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Added test. PR should now be ready for review. |
Techassi
changed the title
Add support for custom class name in compile class transformer
feat(transformer-compile-class): support for custom class names
May 8, 2023
antfu
reviewed
May 9, 2023
4 tasks
Converting to draft for now, let me know when you think are ready. Thanks! |
antfu
reviewed
May 22, 2023
Can we have some tests for it, as well as the custom regex? Thanks |
Added tests in abc2bac. |
antfu
approved these changes
May 23, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom compile class names. The current behavior looks like this:
Which generates something like this:
The PR adds support to customize the compiled class name. It is still possible to customize the trigger (
:<TRIGGER>:
) and the prefix (defaultuno-
). The new trigger syntax is::<TRIGGER>(-NAME):
. This allows the following behavior:The custom compiled class name is added to the
tokens
set. If a duplicate is encountered, an error is thrown.Note
Unrelated to this PR, but still worth a mention: the playground doesn't pass
tokens
in theUnocssPluginContext
. It isundefined
and results in errors when trying to run the compile class transformer. (I guess this also applies to other transformers)