fix(astro): incorrect path and build failure #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Dunqing
changed the title
Dunqing
commented
May 22, 2023
| if (id === UNO_INJECT_ID) | ||
| return id | ||
| if (importer?.endsWith(UNO_INJECT_ID)) | ||
| return `${id}${id.includes('?') ? '&' : '?'}${UNO_QUERY_KEY}` | ||
| if (importer?.endsWith(UNO_INJECT_ID) && config && config.command === 'serve') { |
There was a problem hiding this comment.
need remove && config here @antfu Can you help me?
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #2646
The real file path should be used here, but I don't know why it works in the unocss example.
I have tested it in the broken repo and that work.
And the build failure was also fixed...