feat(vscode): support autocomplete with fuzzy search. #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
antfu
reviewed
Jun 22, 2023
packages/autocomplete/src/utils.ts
Outdated
| * @returns | ||
| */ | ||
| export function searchFuzzy(list: string[], keyword: string) { | ||
| const regex = new RegExp(keyword.split('').join('.*')) |
There was a problem hiding this comment.
Creating a new regex for every change does not sound very efficient to me. Can we use fzf or Fuse.js to do it?
There was a problem hiding this comment.
nice! Fzf can dot it better.
|
Look good! We could have it for now, and later if we make the ordering handles better, we could enable it by default. For example, this should list |
antfu
approved these changes
Jun 23, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
1. Support autocomplete with fuzzy search.
Just like Windicss Intellisense
2023-06-16.11.32.40.mov
this feature need set match type to be 'fuzzy'
2. Add autocomplete max items configure.
For better performance during fuzzy search, we need add a setting for the maximum number of items