Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variant-group): magic-string overwrite error #2834

Merged
merged 1 commit into from Jul 6, 2023

Conversation

chizukicn
Copy link
Contributor

close #2566

If MagicString 's end > original.length , it will out of bounds.

see: https://stackblitz.com/edit/stackblitz-starters-ditjvq?file=index.js

@chizukicn chizukicn requested a review from antfu as a code owner July 5, 2023 17:04
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 166eae3
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64a5a2b7400a2b0008f4ac65
😎 Deploy Preview https://deploy-preview-2834--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sudongyuer sudongyuer enabled auto-merge (squash) July 6, 2023 06:52
@sudongyuer sudongyuer disabled auto-merge July 6, 2023 06:52
@antfu antfu changed the title fix(variant-group): magic overwrite error. fix(variant-group): magic-string overwrite error Jul 6, 2023
@antfu antfu merged commit 36ae01f into unocss:main Jul 6, 2023
10 checks passed
@chizukicn chizukicn deleted the fix/magic-string branch July 6, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extension error when using both transformerVariantGroup() and transformerAttributifyJsx()
2 participants