fix(vite): prepend base on devtools POST_PATH
#2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
When serving an app with vite under a subdirectory, the `POST_PATH` for devtools also has to include the subdirectory when checking the request urls.
flipace
force-pushed
the
fix/vite-dev-subpath
branch
from
f70d7c8
to
e333094
Compare
zyyv
changed the title
base on devtools POST_PATHbase on devtools POST_PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
🐞 When serving an app with
viteunder a subdirectory (iehttp://localhost/admin/) and using the unocss devtools feature, it would send the devtool requests tohttp://localhost/. This led to a 404 as thePOST_PATHwhich unocss checks for is hardcoded as/@unocss-devtools-updateand does not take into account a subpath (/admin/@unocss-devtools-update!==/@unocss-devtools-update)Fix
💅 Prepending the
POST_PATHwith thebaseoption from the vite config allows the devtools to send and receive the request to/on the proper path.