fix(preset-mini): remove grid-gap from generated CSS (deprecated in favor of gap), fix #2642 #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
zyyv
changed the title
zyyv
approved these changes
Jul 15, 2023
antfu
changed the title
|
Though this addressed a bug and fixed the bug, this should have been a breaking change. It removed existing functionality (not in newer browsers, but in the browser I'm stuck developing in). A simple fix for me was to add the rule back into my local preset file. |
|
My bad, didn't mean to break things for anyone 😊 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid-gapwas merged withgap(which works both with flexbox and grid) a few years back so this PR removes it from the generated CSS.grid-column-gap(nowcolumn-gap) andgrid-row-gap(nowrow-gap) are also removed.This should fix a few Vite errors that show up when you use flexbox but end up with
grid-gapin the CSS instead of justgap.As usual I have no idea what I'm doing so it's very possible I may have missed/broken something 😊