Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preset-mini): supplement rule autocomplete #2902

Merged
merged 13 commits into from
Aug 7, 2023
Merged

fix(preset-mini): supplement rule autocomplete #2902

merged 13 commits into from
Aug 7, 2023

Conversation

chizukicn
Copy link
Contributor

@chizukicn chizukicn commented Jul 22, 2023 •
edited

This PR will have these changed.

  1. Supplement rule autocomplete, like absolute and w-full
image

@chizukicn chizukicn requested a review from antfu as a code owner July 22, 2023 16:48
@netlify
Copy link

netlify bot commented Jul 22, 2023 •
edited

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3eecf8
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64cf60d3c1f9790007afacb8
😎 Deploy Preview https://deploy-preview-2902--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

antfu
antfu reviewed Jul 23, 2023
View reviewed changes
packages/preset-mini/src/_rules/position.ts Outdated
Comment on lines 16 to 21
autocomplete: [
makeGroupAutocomplete([
['position', 'pos'],
positionValues,
]),
makeGroupAutocomplete([positionValues]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually prefer to have plain string there. For the position values, we could put it in

unocss/packages/autocomplete/src/parse.ts

Line 6 in 995cc62

export const shorthands: Record<string, string> = {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can add a custom shorthands in preset-mini

@chizukicn chizukicn marked this pull request as draft July 26, 2023 13:01
@chizukicn chizukicn changed the title fix(autocomplete): add position rule autocomplete fix(autocomplete): supplement rule autocomplete Jul 31, 2023
@chizukicn chizukicn marked this pull request as ready for review July 31, 2023 13:52
@chizukicn chizukicn marked this pull request as draft July 31, 2023 13:56
@chizukicn chizukicn changed the title fix(autocomplete): supplement rule autocomplete perf(preset-mini): supplement rule autocomplete Jul 31, 2023
@chizukicn chizukicn changed the title perf(preset-mini): supplement rule autocomplete fix(preset-mini): supplement rule autocomplete Aug 2, 2023
@chizukicn chizukicn marked this pull request as ready for review August 3, 2023 02:25
@chizukicn chizukicn requested a review from antfu August 3, 2023 02:27
@antfu antfu enabled auto-merge August 7, 2023 13:14
@antfu antfu added this pull request to the merge queue Aug 7, 2023
Merged via the queue into unocss:main with commit a1e34b5 Aug 7, 2023
10 checks passed
@chizukicn chizukicn deleted the fix/autocomplete branch August 7, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chizukicn @antfu