Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): cartesian product mistake #2929

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

chizukicn
Copy link
Contributor

When the Cartesian product function is passed in an array of length 1, the return value is mistake.

    const a = ['a', 'b', 'c']
    cartesian([a])
    // we need [['a'],['b'],['c']], not ['a','b','c']

This will cause problems with single-length group autocomplete part when fuzzy matching

@chizukicn chizukicn requested a review from antfu as a code owner July 31, 2023 14:07
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 88f1128
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64c7c032ec633f00082f7d98
😎 Deploy Preview https://deploy-preview-2929--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu added this pull request to the merge queue Jul 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2023
@antfu antfu added this pull request to the merge queue Aug 1, 2023
Merged via the queue into unocss:main with commit 44ec3c8 Aug 1, 2023
10 checks passed
@chizukicn chizukicn deleted the fix/cartsian branch August 2, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants