fix!: add vite as an optional peer dependency to core and astro #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
vonagam
force-pushed
the
add-vite-as-optional-peer
branch
from
96672dc
to
df1b1f7
Compare
vonagam
force-pushed
the
add-vite-as-optional-peer
branch
from
df1b1f7
to
93070d5
Compare
antfu
approved these changes
Aug 9, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2431.
Currently on
unocssinstalls with yarn those warnings are shown:@unocss/vitepeer depends onvite, but neitherunocssnor@unocss/astropackage provide that dependency in any form. Add it as an optional peer dependency to them.