feat(cli)!: add --write-transformed option, disable source write back by default
#2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Aug 7, 2023
packages/cli/src/cli-start.ts
Outdated
| @@ -21,6 +21,7 @@ export async function startCli(cwd = process.cwd(), argv = process.argv, options | |||
| }) | |||
| .option('-c, --config [file]', 'Config file') | |||
| .option('-w, --watch', 'Watch for file changes') | |||
| .option('--update-source', 'Update source files with transformed utilities', { default: true }) | |||
There was a problem hiding this comment.
I feel this was a dangerous default we picked. I'd be happy to name it as --write-transformed and default to false.
There was a problem hiding this comment.
Thanks!
I've updated the flag and made sure that files transformed with directive transformer are also covered by tests.
…sabled by default
…li-toggle-updating-source
antfu
changed the title
--write-transformed option, disable source write back by default
antfu
approved these changes
Aug 9, 2023
1 task
|
Would it be better to output transformed files instead of overwriting source files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this humble PR adds
--update-source--write-transformedflag for@unocss/cliused to toggle overwriting source files with transformed code.It is enabled by default to preserve the current behavior, but can be disabled in case another tool takes care of transforming utility classes on the HTML side.Background:
I'm trying to make UnoCSS work with Rust frameworks preferably without trade-offs like dropping Variant Groups. I've made a little macro for that purpose and hopefully it will evolve someday to be executed on a WASM bundler side rather than polluting source code.
Regardless of the final approach to rendering valid HTML classes, keeping the source files not-transformed is desirable. Otherwise the Variant Groups feature isn't really much of use :)