fix(core): enable details for analyzer #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't actually mind turning |
|
But in this case user will be able to break the Analyzer by setting "details: false" in config. |
antfu
reviewed
Aug 23, 2023
packages/core/src/config.ts
Outdated
| @@ -157,6 +158,7 @@ export function resolveConfig<Theme extends object = object>( | |||
| extractors, | |||
| safelist: getMerged('safelist'), | |||
| separators, | |||
| details: config.details ?? process.env.NODE_ENV === 'development', | |||
There was a problem hiding this comment.
The core is env agnostic, we shouldn't rely on process. Might be better to rely on envMode and move this logics to the vite/webpack plugin
|
@antfu 3rd attempt :) |
antfu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2682
Currently Analyzer shows incorrect info, because
config.detailsis disabled by default.