Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini): add vertical align number/percentage support #3037

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

userquin
Copy link
Member

We need to review the autocompletion, only added |<num> and we should also add something like <percentage>%...

closes #3035

@userquin userquin requested a review from antfu as a code owner August 26, 2023 18:14
@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 2c9b071
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64f0bb800cca9e0008696b27
😎 Deploy Preview https://deploy-preview-3037--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin changed the title feat: add vertical align with number/percentage support feat: add vertical align number/percentage support Aug 26, 2023
@userquin
Copy link
Member Author

We'll have problems with vue directives and vuetify components and the v- prefix in the rule

@zyyv zyyv changed the title feat: add vertical align number/percentage support feat(preset-mini): add vertical align number/percentage support Aug 28, 2023
@antfu antfu enabled auto-merge August 31, 2023 16:13
@antfu antfu disabled auto-merge August 31, 2023 16:20
@antfu antfu merged commit d98e7d3 into main Aug 31, 2023
9 of 10 checks passed
@antfu antfu deleted the userquin/feat-add-vertical-align-support branch August 31, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not support vertical align arbitrary values
3 participants