Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preset-mini): align with theme for zIndex #3062

Merged
merged 3 commits into from
Sep 2, 2023
Merged

feat(preset-mini): align with theme for zIndex #3062

merged 3 commits into from
Sep 2, 2023

Conversation

zyyv
Copy link
Member

@zyyv zyyv commented Sep 2, 2023

close #3049

@zyyv zyyv requested a review from antfu as a code owner September 2, 2023 10:45
@netlify
Copy link

netlify bot commented Sep 2, 2023 •
edited

✅ Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 49eee85
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/64f32991a84071000886150f
😎 Deploy Preview https://deploy-preview-3062--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Dunqing
Dunqing reviewed Sep 2, 2023
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

@zyyv
Copy link
Member Author

zyyv commented Sep 2, 2023

Can you add some tests?

Done.

Dunqing
Dunqing approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@antfu antfu added this pull request to the merge queue Sep 2, 2023
@antfu antfu removed this pull request from the merge queue due to a manual request Sep 2, 2023
@antfu antfu merged commit 965920a into unocss:main Sep 2, 2023
10 checks passed
@zyyv zyyv deleted the mini-theme-zIndex branch October 24, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@Dunqing Dunqing Dunqing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support zIndex in Theme
3 participants
@zyyv @antfu @Dunqing