Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): If uno.root is not set, auto-detection #3069

Merged
merged 14 commits into from Sep 26, 2023
Merged

Conversation

Simon-He95
Copy link
Contributor

@Simon-He95 Simon-He95 commented Sep 3, 2023

With the popularity of monorepo, more and more libraries may use this mode, but it is very troublesome to configure settings.json additionally. I hope to automate changes more intelligently based on the unocss.config of my current project. #3106 #3034 #3009 #2742 #3000

@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit c784ed1
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/65127dc18d9a5400083eb6a0
😎 Deploy Preview https://deploy-preview-3069--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Simon-He95 Simon-He95 reopened this Sep 3, 2023
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
@antfu
Copy link
Member

antfu commented Sep 20, 2023

Also I don't think we should completely remove the unocss.root support, we could have this as a smart default when root is not specified, but keep the original behaviour without breaking change.

@Simon-He95 Simon-He95 changed the title feat(vscode): remove unocss.root and use auto-detection feat(vscode): If uno.root is not set, auto-detection Sep 20, 2023
@Simon-He95
Copy link
Contributor Author

Also I don't think we should completely remove the unocss.root support, we could have this as a smart default when root is not specified, but keep the original behaviour without breaking change.

Thank you for your review, I made some adjustments, please help to check it out

test/assets/variant-group.vue Outdated Show resolved Hide resolved
packages/vscode/package.json Outdated Show resolved Hide resolved
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
packages/vscode/src/index.ts Outdated Show resolved Hide resolved
@Simon-He95
Copy link
Contributor Author

Do you think it is necessary for us to monitor the file name changes or new creations of uno.config?

@antfu antfu added this pull request to the merge queue Sep 26, 2023
@antfu
Copy link
Member

antfu commented Sep 26, 2023

Nice work! Thanks

@antfu antfu removed this pull request from the merge queue due to a manual request Sep 26, 2023
@antfu antfu merged commit ecc477d into unocss:main Sep 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants