Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer-compile-class): add hashExplicitName option, workaround #2366 #3173

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

evanryuu
Copy link
Contributor

Summary

This PR added a hashExplicitName to workaround the duplicated class error in #2866.

Details

#3168 fixes the hmr problem for hashed class names, but when users are using a meaningful compiled class name like :uno-my-class:, it will throw an error since the uno-my-class is already in shortcuts.

Compared to customizing both trigger and classPrefix, it's easier for users to simply add hashExplicitName: true in the options.

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 7a6af69
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/656a67f5f1c156000811d4f1
😎 Deploy Preview https://deploy-preview-3173--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evanryuu evanryuu changed the title feat(transformer-compile-explicit): add hashExplicitName option, workaround #2366 feat(transformer-compile-class): add hashExplicitName option, workaround #2366 Sep 26, 2023
Copy link

stale bot commented Nov 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 25, 2023
@stale stale bot removed the stale label Dec 1, 2023
@antfu antfu merged commit 08e2397 into unocss:main Dec 2, 2023
9 checks passed
@evanryuu evanryuu deleted the feat/transformer-compile-explicit branch December 2, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants