Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): resize editor panes #3249

Merged
merged 5 commits into from Oct 21, 2023

Conversation

2hu12
Copy link
Contributor

@2hu12 2hu12 commented Oct 19, 2023

Fix the the inconsistency of pane toggle state and pane title overlape when window resizing. Make sure that there's at least one pane is unfolded/uncollapsed to keep the consistency between clicking toggle and dragging toggle, since you just cann't drag every pane to the min size.

Before

bug.mov

After

fix.mov

@2hu12 2hu12 requested a review from antfu as a code owner October 19, 2023 17:23
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4b93627
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6533ecdb5ef7700008d3a841
😎 Deploy Preview https://deploy-preview-3249--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu enabled auto-merge October 21, 2023 18:14
@antfu antfu added this pull request to the merge queue Oct 21, 2023
Merged via the queue into unocss:main with commit 7a4fd15 Oct 21, 2023
9 checks passed
@2hu12 2hu12 deleted the fix-playground-pane-resize branch October 22, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants