Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preset-mini,preset-wind)!: fix broken color/opacity syntax #3359

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

chu121su12
Copy link
Collaborator

The shorthand doesn't work with the spaced color syntax due to encountering multiple separator (/, ex. bg-[rgba(4_5_6/0.7)]/80, see test) with naive split. However, introducing the fix requires moving the bg-x rules over to preset mini.

I think it can be done without breaking but the rule & test might be altered significantly.

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 56a06ca
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/655b3abf2e0f4300083fe368
😎 Deploy Preview https://deploy-preview-3359--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chu121su12 chu121su12 marked this pull request as ready for review November 20, 2023 11:00
@antfu antfu merged commit 3eeac2b into unocss:main Nov 29, 2023
9 checks passed
@chu121su12 chu121su12 deleted the fix/shorthand branch November 29, 2023 15:22
@jsardev jsardev mentioned this pull request Feb 3, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants