fix(eslint-plugin): blocklist rule cant match variants
#3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Nov 22, 2023
packages/eslint-plugin/src/worker.ts
Outdated
| return [...extracted.values()].filter(i => uno.isBlocked(i)) | ||
| const values = [...extracted.values()] | ||
| const blocked = await Promise.all(values.map(i => uno.isBlockedWithStrict(i))) | ||
| return values.filter((_, i) => blocked[i]) |
There was a problem hiding this comment.
If it's an eslint only feature, how about moving it out of core? Ideally we could have an option for it (I am ok with default strict)
There was a problem hiding this comment.
I prefer to support strict mode directly in isBlocked. I need to spend some time researching how to implement a simple sync API that removes variants
chizukicn
changed the title
isBlockedWithStrict functionblocklist rule cant match variants
|
It seems that it is unrealistic to handle variants synchronously, I moved this function into |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new function
isBlockedWithStrictto uno generator and fix the problem that eslint-plugin blocklist cannot match variantsbefore: It is actually blocked, but eslint-plugin will not prompt
after:
