Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-mini): remove outline-color in color properties #3527

Closed
4 tasks done
mrguamos opened this issue Jan 23, 2024 · 3 comments
Closed
4 tasks done

feat(preset-mini): remove outline-color in color properties #3527

mrguamos opened this issue Jan 23, 2024 · 3 comments

Comments

@mrguamos
Copy link

Clear and concise description of the problem

changes made with this PR #2116 were actually reverted from tailwind
tailwindlabs/tailwindcss#10604

Suggested solution

perhaps we should also revert these?

Alternative

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the README.md of using the package.
  • Already used the Interactive Docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@Simon-He95
Copy link
Contributor

Are you interested in submitting a PR?

@henrikvilhelmberglund
Copy link
Contributor

I took another look at this and think focus:outline-none is the real jank. You can both keep the ability to use transitions without glitches by using outline-none instead of focus:outline-none, and also use transitions on outlines when not using outline-none.

Tailwind chose to just revert the change because (I think) big packages used focus:outline-none instead of outline-none and the change broke those packages. To be fair focus:outline-none is used in the docs instead of outline-none so it is officially condoned jank in this case.

This could be changed like they did so people don't run into this issue but you can also avoid this issue by not using focus:outline-none when using transitions.

playground

@Simon-He95 Simon-He95 closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants