Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): completion color #3632

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(vscode): completion color #3632

merged 1 commit into from
Mar 18, 2024

Conversation

Simon-He95
Copy link
Contributor

At present, vscode does not seem to support the use of rgb (r g b / a) form. I think it can be temporarily converted to rgba form and give color tips. If vscode supports it later, it will be removed.

image

image

image

@Simon-He95 Simon-He95 requested a review from antfu as a code owner March 18, 2024 02:50
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f23a15
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/65f7abfc03ed260008c9165b
😎 Deploy Preview https://deploy-preview-3632--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zyyv
Copy link
Member

zyyv commented Mar 18, 2024

Hi, is this a new feature?
Please test this, if it was a shortcut that contained multiple colors, what would it show?

@Simon-He95
Copy link
Contributor Author

Hi, is this a new feature?你好,这是新功能吗? Please test this, if it was a shortcut that contained multiple colors, what would it show? 请测试一下,如果是包含多种颜色的快捷方式,会显示什么?

Because the form that was previously synchronized to tailwind was changed to rgb(), but we have transparency, vscode does not seem to recognize the form of rgb (r g b / a). For the sake of compatibility, it is processed into rgba when prompted by the vscode plug-in.

@antfu antfu added this pull request to the merge queue Mar 18, 2024
Merged via the queue into unocss:main with commit 060926b Mar 18, 2024
9 checks passed
@Simon-He95 Simon-He95 deleted the vscode-color branch March 29, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants