Skip to content

feat(preset-mini): support (float|clear)-(start|end) #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

OverflowCat
Copy link
Contributor

Add logical support for float and clear: float-start, float-end, clear-start, and clear-end. Tailwind has added these.

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 27c2624
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/66a3b955d39025000809dc02
😎 Deploy Preview https://deploy-preview-3997--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OverflowCat OverflowCat force-pushed the feat-float-clear-start-end branch from a70530e to f0ecf4b Compare July 18, 2024 04:52
@OverflowCat OverflowCat marked this pull request as ready for review July 18, 2024 04:52
@OverflowCat OverflowCat requested a review from antfu as a code owner July 18, 2024 04:52
@OverflowCat
Copy link
Contributor Author

I'm not entirely sure, but it seems like the CI failures might not be directly related to the changes in this PR. src/_preprocess/transformApply/getUtils.test.ts has no clear or float class names.

@henrikvilhelmberglund
Copy link
Contributor

That test has a snapshot of the utility count so whenever you add utilities you have to increment the number in the snapshot. Eg. you added 4 utilities so the number went from 86 to 90.

The test should probably be fixed.

@antfu antfu added this pull request to the merge queue Jul 26, 2024
Merged via the queue into unocss:main with commit 093c5ab Jul 26, 2024
9 checks passed
OverflowCat added a commit to OverflowCat/blog that referenced this pull request Jul 29, 2024
@OverflowCat OverflowCat deleted the feat-float-clear-start-end branch July 29, 2024 01:36
Simon-He95 pushed a commit to Simon-He95/unocss that referenced this pull request Nov 30, 2024
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants