Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape selector in typography #819

Merged
merged 6 commits into from May 7, 2022
Merged

fix: escape selector in typography #819

merged 6 commits into from May 7, 2022

Conversation

ydcjeff
Copy link
Member

@ydcjeff ydcjeff commented Apr 12, 2022

@ydcjeff ydcjeff requested a review from antfu as a code owner April 12, 2022 07:32
@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for unocss failed.

Name Link
🔨 Latest commit 09466bf
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/627687232f117c0009c81f43

@ydcjeff
Copy link
Member Author

ydcjeff commented Apr 12, 2022

Wait, playground seems not working. (This is an edge bug when using attribute and class mode together.)

This PR fixes the original bug of the linked issue: playground

will do follow up PR to fix the edge bug.

@ydcjeff ydcjeff enabled auto-merge (squash) April 12, 2022 09:32
@zyyv
Copy link
Member

zyyv commented Apr 12, 2022

Wait, playground seems not working. (This is an edge bug when using attribute and class mode together.)

This PR fixes the original bug of the linked issue: playground

will do follow up PR to fix the edge bug.

Still have problems
playground

@antfu antfu disabled auto-merge April 12, 2022 21:53
@antfu antfu marked this pull request as draft April 12, 2022 21:53
@chu121su12
Copy link
Collaborator

If I may, why we are not using logic for attributifyPseudo in preset-mini?

/**
* @default false
*/
attributifyPseudo?: Boolean

export const variants = (options: PresetMiniOptions): Variant<Theme>[] => [

...variantTaggedPseudoClasses(options),

export const variantTaggedPseudoClasses = (options: PresetMiniOptions = {}): VariantObject[] => {
const attributify = !!options?.attributifyPseudo
return [
{
match: taggedPseudoClassMatcher('group', attributify ? '[group=""]' : '.group', ' '),

@ydcjeff ydcjeff marked this pull request as ready for review May 7, 2022 14:35
@ydcjeff
Copy link
Member Author

ydcjeff commented May 7, 2022

any idea why docs is failing?

@antfu antfu merged commit 634847a into main May 7, 2022
@antfu antfu deleted the gh-795 branch May 7, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"prose" default styles are not applied with attributify
4 participants