Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): update @apply when config changed #837

Merged
merged 2 commits into from Apr 21, 2022
Merged

Conversation

action-hong
Copy link
Contributor

@action-hong action-hong requested a review from antfu as a code owner April 17, 2022 11:51
@netlify
Copy link

netlify bot commented Apr 17, 2022

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit 02ea03b
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/625c3c74916bca0008b1af8c
😎 Deploy Preview https://deploy-preview-837--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@action-hong
Copy link
Contributor Author

action-hong commented Apr 17, 2022

wait it still have some problem,

when there is no transformerDirectives in config in the first time, then i add transformerDirectives, some css hmr will be not working

i am no sure it is a good way to cache all css module and update them when config changed

{
  resolveId(id) {
     if (id.match(regexCssId))
         modules.add(id)
  }
...
}

@antfu antfu merged commit 336c5b9 into unocss:main Apr 21, 2022
@action-hong action-hong deleted the fix/hmr branch April 21, 2022 05:56
antfu added a commit that referenced this pull request May 1, 2022
antfu added a commit that referenced this pull request May 1, 2022
This reverts commit 336c5b9.
0x088730 pushed a commit to 0x088730/unocss that referenced this pull request Sep 16, 2022
This reverts commit 336c5b93bdee55489a138ecb8c3e16b6ec9bfd63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants