fix: escape , properly
#941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss canceled.
|
alexanderniebuhr
changed the title
|
I am more than happy to do some more test, if requested with some test items. |
antfu
changed the title
, properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the escape char of
,to be\,instead of\2c. I suggest this change because using uno with svelte scoping breaks. Svelte removes unused styles (if scoped), and does not recognise the\2cas the same class in the markup.I tested the browser support (using online test grids) for the example of
grid-cols-[repeat(6,1fr)]Desktop (https://github.com/alexanderniebuhr/lambda-test/blob/main/TES100201621651772638589250.pdf)
Mobile (https://github.com/alexanderniebuhr/lambda-test/blob/main/TES100201621651774781769360.pdf)
Everything seems to work, except IE. But the browser does not support grid, so I expect that. However IE should work with supported rules with
,in them.According to newest brower's dev tools, the generated css class is the same with both escape chars (see attached screenshot).
closes #939