Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reset): update from tailwind reset #945

Merged
merged 3 commits into from May 7, 2022
Merged

feat(reset): update from tailwind reset #945

merged 3 commits into from May 7, 2022

Conversation

chu121su12
Copy link
Collaborator

@chu121su12 chu121su12 commented May 7, 2022

I just noticed there's new flex reset here. Should the .dark block be removed in the tailwind reset?

@chu121su12 chu121su12 requested a review from antfu as a code owner May 7, 2022 03:42
@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for unocss canceled.

Name Link
🔨 Latest commit a701d26
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6275f8effbfabf00086f5446

@chu121su12 chu121su12 marked this pull request as draft May 7, 2022 03:46
@chu121su12 chu121su12 marked this pull request as ready for review May 7, 2022 03:58
@antfu
Copy link
Member

antfu commented May 7, 2022

Should the .dark block be removed in the tailwind reset?

Sure I am fine with it.

remove `.dark` reset
@antfu antfu changed the title chore(reset): update from tailwind reset feat(reset): update from tailwind reset May 7, 2022
@antfu antfu merged commit 8b4bc3d into main May 7, 2022
@antfu antfu deleted the chu121su12-patch-1 branch May 7, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants